Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean ups #6066

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Clean ups #6066

merged 4 commits into from
Oct 27, 2021

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Oct 11, 2021

No description provided.

@SpacePossum SpacePossum marked this pull request as draft October 11, 2021 08:50
@coveralls
Copy link

coveralls commented Oct 11, 2021

Coverage Status

Coverage decreased (-0.02%) to 92.81% when pulling 3bfe426 on SpacePossum:master_shorthand_operator into ef44dce on FriendsOfPHP:master.

@SpacePossum SpacePossum changed the title Clean up duplicate code LongToShorthandOperator - introduction Oct 19, 2021
@SpacePossum SpacePossum marked this pull request as ready for review October 27, 2021 20:15
@SpacePossum SpacePossum changed the title LongToShorthandOperator - introduction Clean ups Oct 27, 2021
@SpacePossum SpacePossum merged commit 7f6aff4 into PHP-CS-Fixer:master Oct 27, 2021
@SpacePossum SpacePossum deleted the master_shorthand_operator branch October 27, 2021 20:17
@@ -49,7 +49,7 @@

<php>
<ini name="zend.enable_gc" value="0"/>
<ini name="memory_limit" value="1G"/>
<ini name="memory_limit" value="10G"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why, @SpacePossum ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you run with code coverage 1G is never enough... we just added to much tests : )

Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants