ConcatWithoutSpacesFixer, OperatorsSpacesFixer- fix too many spaces, fix incorrect fixing of lines with comments #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
changed the title
keradus
changed the title
…fix incorrect fixing of lines with comments
keradus
added a commit
that referenced
this pull request
Jul 23, 2016
…y spaces, fix incorrect fixing of lines with comments (SpacePossum) This PR was merged into the 1.11 branch. Discussion ---------- ConcatWithoutSpacesFixer, OperatorsSpacesFixer- fix too many spaces, fix incorrect fixing of lines with comments closes #1589 Should apply without any problems on 1.12, however on 1.12 there are two fixers with a CS problem that will be fixed by the fixers changed in this PR. So on merging upstream please fix the CS there (guess who the author is of those two fixers with the CS problem... ;) ). Commits ------- 245d14a ConcatWithoutSpacesFixer, OperatorsSpacesFixer- fix too many spaces, fix incorrect fixing of lines with comments
|
great work, thanks @SpacePossum ! |
| array( | ||
| '<?php [1, 2] + // | ||
| [3, 4];', | ||
| '<?php [1, 2] + // |
There was a problem hiding this comment.
trailing spaces, fixed on 1.12, ignored on 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1589
Should apply without any problems on 1.12,
however on 1.12 there are two fixers with a CS problem that will be fixed by the fixers changed in this PR. So on merging upstream please fix the CS there (guess who the author is of those two fixers with the CS problem... ;) ).