Detect extra old installations #2946
Conversation
| } | ||
|
|
||
| foreach ($warningsDetector->getWarnings() as $warning) { | ||
| $stdErr->writeln(sprintf($stdErr->isDecorated() ? '<bg=yellow;fg=black;>%s</>' : '%s', $warning)); |
There was a problem hiding this comment.
Is the isDecorated() check needed? I think Symfony does it internally anyway.
There was a problem hiding this comment.
it's moved 1-1 from FixCommand, no idea
There was a problem hiding this comment.
Just tried, I confirm that Symfony internally strips style tags when needed. However there are other places where this check could be dropped so, if you agree, I'll do this in a separate PR.
There was a problem hiding this comment.
let's go with separated PR indeed, input from person who did this check originally would be nice as well
There was a problem hiding this comment.
stdErr is an instance of OutputInterface and we don't check the formatter, so I think we cannot be sure escaping is done here always? If we assume we can rely on this on other places than lets remove the check here as well in a new PR, otherwise lets leave as is ;)
Symfony/CS/ToolInfo.php
Outdated
| if (self::COMPOSER_PACKAGE_NAME === $package['name']) { | ||
| $result = $package['version'].'#'.$package['dist']['reference']; | ||
| if ( | ||
| self::COMPOSER_PACKAGE_NAME === $package['name'] || |
|
@localheinz , maybe you could take a look on this and review it please ? |
|
Almost 30% is still using v1. Let us hope with this change it will decrease |
This PR was squashed before being merged into the 1.13 branch (closes #2946). Discussion ---------- Detect extra old installations When instlaled via composer, there are about: - 2500 daily installation with old vendor name (regardless of version) - 3000 daily installation of v1 (with new vendor name) For that, we have >5k daily downloads of version we do not support. Let us try to reduce that numer. Commits ------- 93e764c Detect extra old installations
|
Ha, apologies for the delay! |
|
no issue, I assumed you were not interested in this ;) |
When instlaled via composer, there are about:
For that, we have >5k daily downloads of version we do not support.
Let us try to reduce that numer.