Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated PHPUnit assertions #4061

Closed
wants to merge 1 commit into from
Closed

Use dedicated PHPUnit assertions #4061

wants to merge 1 commit into from

Conversation

carusogabriel
Copy link
Contributor

No description provided.

@ntzm
Copy link
Contributor

ntzm commented Oct 22, 2018

Would be better to add this logic to PhpUnitDedicateAssertFixer

@SpacePossum
Copy link
Contributor

SpacePossum commented Oct 23, 2018

the first proposed change weakens the tests, for example;

    public function testABC()
    {
        $a = 'abc';
        $this->assertContains('a', $a);
        $this->assertTrue(\in_array('a', $a, true));
    }

first passes, second fails

@carusogabriel
Copy link
Contributor Author

@SpacePossum Thanks for that. I'll follow what @ntzm said and improve our Fixers to automatically fix them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants