Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.3] IsNullFixer - support PHP 7.3 #4187

Merged
merged 1 commit into from Jan 1, 2019
Merged

[7.3] IsNullFixer - support PHP 7.3 #4187

merged 1 commit into from Jan 1, 2019

Conversation

kubawerlos
Copy link
Contributor

After #4186

@keradus
Copy link
Member

keradus commented Dec 31, 2018

I believe that atomic fixes to different rules shall also add respective part to integration test, taken from #4184

@SpacePossum
Copy link
Contributor

wonder why the tests are executed on PHP 7 on travis...

@keradus keradus added this to the 2.12.5 milestone Dec 31, 2018
@keradus keradus changed the title [7.3] IsNullFixer - add tests for PHP7.3 [7.3] IsNullFixer - support PHP 7.3 Dec 31, 2018
@keradus keradus added RTM Ready To Merge and removed RTM Ready To Merge labels Dec 31, 2018
@keradus keradus mentioned this pull request Dec 31, 2018
Closed
20 tasks
keradus
keradus requested changes Dec 31, 2018
View reviewed changes
Copy link
Member

@keradus keradus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing on 7.3

@kubawerlos
Copy link
Contributor Author

Updating as mentioned in description.

@SpacePossum SpacePossum added the RTM Ready To Merge label Jan 1, 2019
@keradus keradus removed the RTM Ready To Merge label Jan 1, 2019
@keradus
Copy link
Member

keradus commented Jan 1, 2019

Thank you @kubawerlos.

@keradus keradus merged commit 3526663 into PHP-CS-Fixer:2.12 Jan 1, 2019
keradus added a commit that referenced this pull request Jan 1, 2019
@keradus
minor #4187 [7.3] IsNullFixer - support PHP 7.3 (kubawerlos)
666bce8 
This PR was merged into the 2.12 branch.

Discussion
----------

[7.3] IsNullFixer - support PHP 7.3

After #4186

Commits
-------

3526663 [7.3] IsNullFixer - support PHP 7.3
@kubawerlos kubawerlos deleted the fix-php73-is-null branch January 1, 2019 17:30
@guilliamxavier guilliamxavier mentioned this pull request Jan 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntzm ntzm ntzm requested changes

@keradus keradus keradus requested changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
2.12.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubawerlos @keradus @SpacePossum @ntzm