PhpUnitTestCaseStaticMethodCallsFixer - fix for having property with name as method to update #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems to work for me 👍 |
SpacePossum
approved these changes
Feb 17, 2019
Slamdunk
approved these changes
Mar 3, 2019
tests/Fixer/PhpUnit/PhpUnitTestCaseStaticMethodCallsFixerTest.php
Outdated
Show resolved
Hide resolved
…name as method to update
|
Thank you @kubawerlos. |
SpacePossum
added a commit
that referenced
this pull request
Mar 18, 2019
…erty with name as method to update (kubawerlos, SpacePossum) This PR was squashed before being merged into the 2.12 branch (closes #4314). Discussion ---------- PhpUnitTestCaseStaticMethodCallsFixer - fix for having property with name as method to update Fixes #4312 Pinging @Slamdunk (as original author) and @ro0NL (as reporter) for review. Commits ------- 2e5756c PhpUnitTestCaseStaticMethodCallsFixer - fix for having property with name as method to update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4312
Pinging @Slamdunk (as original author) and @ro0NL (as reporter) for review.