CommentToPhpdocFixer - allow to ignore tags #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @julienfalque , can you take a look please? |
julienfalque
requested changes
Jun 4, 2019
| <?php /* header comment */ $foo = true; | ||
|
|
||
| // @todo do something later | ||
| $foo = 1; |
There was a problem hiding this comment.
Please add a test case with a comment before a structural element, I think the added tests here would still pass without the ignored_tags, thus they don't prove the option works as expected.
There was a problem hiding this comment.
What do you mean? Isn't this case with a comment before a structural element? Can you prepare the one you are thinking about?
There was a problem hiding this comment.
Actually I misunderstood the code, sorry.
julienfalque
approved these changes
Jun 5, 2019
|
Thank you @kubawerlos. |
SpacePossum
added a commit
that referenced
this pull request
Jul 25, 2019
This PR was merged into the 2.16-dev branch. Discussion ---------- CommentToPhpdocFixer - allow to ignore tags Resolves #3628 Ping @julienfalque for review, I've made the list case insensitive - I figured it's more natural, would you agree? Commits ------- 0a46405 CommentToPhpdocFixer - allow to ignore tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3628
Ping @julienfalque for review, I've made the list case insensitive - I figured it's more natural, would you agree?