Enable testing with PHPUnit 9.x #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
commented
Dec 3, 2020
sanmai
commented
Dec 3, 2020
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
6d17764
to
1a24bfd
Compare
sanmai
commented
Dec 3, 2020
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
0ecce90
to
4dc8aae
Compare
sanmai
commented
Dec 4, 2020
| @@ -62,7 +62,7 @@ protected function doTest($expected, $input = null, \SplFileInfo $file = null) | |||
| protected function configureFixerWithAliasedOptions(array $configuration) | |||
| { | |||
| if (!$this->fixer instanceof ConfigurationDefinitionFixerInterface) { | |||
| throw new \LogicException('Fixer is not configurable'); | |||
| throw new \LogicException('Fixer is not configurable.'); | |||
There was a problem hiding this comment.
Fabbot asked for this and below.
|
I will try to get this up to date with the head branch next Monday. |
sanmai
commented
Dec 5, 2020
sanmai
commented
Dec 5, 2020
| @@ -40,9 +40,10 @@ | |||
| "php-cs-fixer/accessible-object": "^1.0", | |||
| "php-cs-fixer/phpunit-constraint-isidenticalstring": "^1.2", | |||
| "php-cs-fixer/phpunit-constraint-xmlmatchesxsd": "^1.2.1", | |||
| "phpunit/phpunit": "^5.7.27 || ^6.5.14 || ^7.1", | |||
| "phpunit/phpunit": "^5.7.27 || ^6.5.14 || ^7.5.20 || ^8.5.13 || ^9.4.4 <9.5", | |||
There was a problem hiding this comment.
PHPUnit-Bridge is not yet compatible with PHPUnit 9.5. Looks like this.
Reported as symfony/symfony#39329
There was a problem hiding this comment.
It is, but not in a release. Right?
derrabus
reviewed
Dec 5, 2020
keradus
force-pushed
the
pr/2.16/phpunit9
branch
2 times, most recently
from
3bc09d8
to
34f663e
Compare
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
19bf9b2
to
4db3664
Compare
kubawerlos
reviewed
Dec 8, 2020
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
4db3664
to
3d75d69
Compare
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
3d75d69
to
c8acb1b
Compare
kubawerlos
reviewed
Dec 9, 2020
| @@ -74,12 +74,27 @@ public function testDeploymentJobsRunOnLatestStablePhpThatIsSupportedByTool() | |||
| } | |||
| } | |||
|
|
|||
| private static function assertUpcomingPhpVersionIsCoveredByCiJob($lastSupportedVersion, array $ciVersions) | |||
| private static function ensureTraversableContainsIsAvailable() | |||
There was a problem hiding this comment.
What is the purpose here?
It is named "ensure TraversableContains is available" and when it does not exist we mark it as skipped.
There was a problem hiding this comment.
Yup, that's what it does. Is there a problem?
There was a problem hiding this comment.
Contrary to what the diff shows, assertUpcomingPhpVersionIsCoveredByCiJob is still here.
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
2 times, most recently
from
9d3044e
to
6712f4e
Compare
|
Diff should be much smaller now. Please check it out. |
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
2 times, most recently
from
bd6ed51
to
40cef3a
Compare
- Replace setUp/tearDown. - Refactor propery-accessing static methods. - Fix fabbot.io notices. - Bumps timeout for small tests. - Update composer.json. Co-authored-by: Alexey Kopytko <alexey@kopytko.com>
sanmai
force-pushed
the
pr/2.16/phpunit9
branch
from
40cef3a
to
4dee7ec
Compare
kubawerlos
approved these changes
Dec 13, 2020
|
Thank you @sanmai. |
|
thanks for all the work @sanmai 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5262
Uses PHPUnit 9.4 on PHP 8: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/5314/checks?check_run_id=1491483701#step:9:9