Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: do not use deprecated create method #5344

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Update docs: do not use deprecated create method #5344

merged 1 commit into from
Dec 14, 2020

Conversation

SpacePossum
Copy link
Contributor

No description provided.

@SpacePossum SpacePossum changed the base branch from 2.17 to 2.16 December 9, 2020 15:48
@SpacePossum SpacePossum added this to the 2.16.10 milestone Dec 9, 2020
Copy link
Member

@julienfalque julienfalque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@keradus keradus added the RTM Ready To Merge label Dec 9, 2020
@@ -19,7 +19,8 @@ $finder = PhpCsFixer\Finder::create()
])
;

$config = PhpCsFixer\Config::create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we go with $config = (new PhpCsFixer\Config())?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not available in each supported PHP version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, so it started to work since 5.4? i though that only 7.0.
nice ;)

@SpacePossum SpacePossum merged commit bccc9af into PHP-CS-Fixer:2.16 Dec 14, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Dec 14, 2020
@SpacePossum SpacePossum deleted the 2_16_update_docs_for_config_create branch December 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants