Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMixedEchoPrintFixer: fix for conditions without curly brackets #5561

Merged
merged 1 commit into from
Apr 3, 2021
Merged

NoMixedEchoPrintFixer: fix for conditions without curly brackets #5561

merged 1 commit into from
Apr 3, 2021

Conversation

kubawerlos
Copy link
Contributor

@kubawerlos kubawerlos commented Mar 21, 2021

Fixes #5539

In separate PR I will refactor other test cases to have more shared snippets to convert in both ways, I didn't want to do that in this PR to make this PR simpler.

@coveralls
Copy link

coveralls commented Mar 21, 2021

Coverage Status

Coverage remained the same at 91.849% when pulling 8d8d053 on kubawerlos:fix_no_mixed_echo_print into 6511119 on FriendsOfPHP:2.18.

@kubawerlos kubawerlos closed this Mar 21, 2021
@kubawerlos kubawerlos reopened this Mar 21, 2021
@keradus keradus added this to the 2.18.5 milestone Mar 22, 2021
@keradus
Copy link
Member

keradus commented Apr 3, 2021

Thank you @kubawerlos.

@keradus keradus merged commit f669ea6 into PHP-CS-Fixer:2.18 Apr 3, 2021
@keradus
Copy link
Member

keradus commented Apr 3, 2021

@kubawerlos , mind to create a php 5.6 syntax cleanup and recover yield from construction for 3.x line?

@kubawerlos kubawerlos deleted the fix_no_mixed_echo_print branch April 3, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_mixed_echo_print may ignore one-line structure body
4 participants