Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority fix: SingleSpaceAfterConstructFixer must run before BracesFixer #5563

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Priority fix: SingleSpaceAfterConstructFixer must run before BracesFixer #5563

merged 1 commit into from
Mar 22, 2021

Conversation

kubawerlos
Copy link
Contributor

Fixes #5559

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 91.849% when pulling 4e77042 on kubawerlos:fix_SingleSpaceAfterConstructFixer_must_run_before_BracesFixer into c409758 on FriendsOfPHP:2.18.

@kbond
Copy link

kbond commented Mar 22, 2021

After upgrading to 2.18.4, function_declaration (space one) is no longer working - will this fix that as well?

@kubawerlos
Copy link
Contributor Author

@kbond I'm afraid no, can you report an issue with some sample code?

@keradus keradus added this to the 2.18.5 milestone Mar 22, 2021
@keradus
Copy link
Member

keradus commented Mar 22, 2021

Thank you @kubawerlos.

@keradus keradus merged commit d617223 into PHP-CS-Fixer:2.18 Mar 22, 2021
@@ -0,0 +1,19 @@
--TEST--
Integration of fixers: single_space_after_construct,braces.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(yes, I know we have open discussion here. let's discuss in other thread to not block this PR)

@kubawerlos kubawerlos deleted the fix_SingleSpaceAfterConstructFixer_must_run_before_BracesFixer branch March 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.18.4 single_space_after_construct bug
4 participants