SSH URL Update #105
SSH URL Update #105
Conversation
This reverts commit 3ea741c.
System now accepts SSH URLs and Github SSH Urls
| @@ -38,6 +38,9 @@ public function setRepository($url) | |||
| } elseif (preg_match('#^[a-z0-9_-]+/[a-z0-9_-]+$#i', $this->getRepository())) { | |||
| $this->setUrlPattern(sprintf('https://github.com/%s/commit/%%commit%%', $this->getRepository())); | |||
| parent::setRepository(sprintf('https://github.com/%s.git', $this->getRepository())); | |||
| } elseif (preg_match('#^git@github.com:[a-z0-9_-]+/[a-z0-9_-]+\.git@?([a-z0-9_-]+)?$#i', $url)) { | |||
|
Vote for this 👍 |
|
ping @quantum-x |
|
Hi guys. On Sun, Dec 1, 2013 at 4:42 PM, Grégoire Pineau notifications@github.comwrote:
|
|
I had to patch this for my local installation. Also vote for this. 👍 |
|
Apologies for the delay - I am incredibly swamped with real-life. If I've missed something, I'm going to have to pass the baton to someone else; not sure I have the time unfortunately. Fingers crossed that all is good. |
|
Test does no pass on travis. |
|
C'est bien possible que je l'ai mal fait. On Thu, Feb 6, 2014 at 5:24 PM, Grégoire Pineau notifications@github.comwrote:
|
|
Closing as there is no update. Feel free to re-open. |
Hi guys.
IE:
$projects[] = new Sismo\GithubProject('Project Dev Branch', 'git@github.com:people/project.git@dev', $notifier);
or just as happily
$projects[] = new Sismo\GithubProject('Project Dev Branch', 'user@othersite.com:people/project.git', $notifier);
First PR, please be gentle.