Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Spread adoption to your favorite SDKs #2

Closed
nicolas-grekas opened this issue Oct 21, 2022 · 4 comments
Closed

Spread adoption to your favorite SDKs #2

nicolas-grekas opened this issue Oct 21, 2022 · 4 comments

Comments

@nicolas-grekas
Copy link
Collaborator

nicolas-grekas commented Oct 21, 2022

As stated in the README:

If your favorite SDK does not use this package yet, please let them know about it or better: send them a PR!

I'm creating this issue to keep track of such initiatives.
Please link back and/or drop a comment here when applicable.

See e.g.
composer/composer#6758
getsentry/sentry-php#1411
async-aws/aws#1318

Packages dependent on supported abstractions:

See also https://packagist.org/packages/php-http/discovery/dependents?order_by=downloads

@nicolas-grekas nicolas-grekas changed the title Spread adoption to major SDKs Spread adoption to your facorite SDKs Oct 21, 2022
@nicolas-grekas nicolas-grekas changed the title Spread adoption to your facorite SDKs Spread adoption to your favorite SDKs Oct 21, 2022
@ostrolucky
Copy link

https://github.com/aws/aws-sdk-php could be a big win

@nicolas-grekas
Copy link
Collaborator Author

nicolas-grekas commented Oct 25, 2022

aws/aws-sdk-php could be a big win

I spent a few hours on this and my conclusion is that aws-sdk-php is too coupled to Guzzle: many things are configured via request options and those are Guzzle-specific. It would be possible to map them to Symfony HttpClient's option, but that wouldn't solve anything related to this discussion since here we're talking about coding against abstractions (PSR-18 / HTTPlug), and none of these abstractions support said options (excerpt: sink, http_stats_receiver, decode_content, stream, delay, headers.Accept-Encoding, curl.CURLOPT_TCP_KEEPALIVE, debug, proxy, verify, timeout, connect_timeout. etc.)

TL;DR: use https://github.com/async-aws/aws instead.

@nicolas-grekas
Copy link
Collaborator Author

Closing in favor of php-http/discovery#208

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants