Symfony 4.4 compatibility: use Either ErrorListener or ExceptionListener

[bendavies]

This bundle currently has integration with with the symfony ExceptionListener here:

https://github.com/FriendsOfSymfony/FOSRestBundle/blob/7705fa0af878f28d56a182dea4f18c1e0ab9cbbb/EventListener/ExceptionListener.php

In symfony 4.4 this class is deprecated in favor of ErrorListener.

A Compiler Pass is used to use either one or the other.

This bundle needs support for both eventualities/listeners.

[maxhelias]

Should be fixed by #2025

[XWB]

#2025

[bendavies]

That PR does not resolve the issue. please reopen.

[xabbuh]

Can you provide some more information on what happens?

[bendavies]

This is converting the Exception to a FlattenedException, because the parameter here has no type.

Which results in a type error here:
TypeError: Argument 1 passed to FOS\RestBundle\Controller\ExceptionController::getStatusCode() must be an instance of Exception, instance of Symfony\Component\ErrorHandler\Exception\FlattenException given

Adding a type to $exception would fix it.

But like i said in OP,

This bundle is uses the deprecated ExceptionListener

In symfony 4.4 this class is deprecated in favor of ErrorListener.

This bundle needs to detect if the consumer is using either Symfony/Component/HttpKernel/EventListener/ExceptionListener or Symfony/Component/Console/EventListener/ErrorListener, and use the same. It will always be one or the other due to this compiler pass

[bendavies]

related: since this bundle now supports symfony 5, this is totally broken since the class doesn't exist.

[yceruto]

Yes, I can confirm that #2025 does not work in 5.0 and triggers another deprecation on 4.4. The ExceptionListener was deprecated while PR was alive.

I will try to rework it this weekend.

[yceruto]

See #2036

[seddighi78]

how to fix this problem in Symfony 4.4?

[yceruto]

#2036 already fix this problem on 4.4, but it's not merged yet.

[emimarz]

when going to merge it? because I have the same error

[emimarz]

are there a work around for this? meanwhile

[The-Don-Himself]

are there a work around for this? meanwhile

@emimarz this hack seems to solve it for me and a few others on Symfony 4.4

#2036 (comment)