Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI doesn't check the crate using 1.34.0 #90

Closed
Lokathor opened this issue Aug 5, 2020 · 1 comment
Closed

CI doesn't check the crate using 1.34.0 #90

Lokathor opened this issue Aug 5, 2020 · 1 comment

Comments

@Lokathor
Copy link
Contributor

Lokathor commented Aug 5, 2020

The readme says that the crate should build with 1.34.0, but this isn't confirmed on a regular basis by the CI.

@Alphare
Copy link

Alphare commented Aug 13, 2020

I am trying to use flate2 (to implement some of the core tools within Mercurial), which has a dependency on miniz_oxide. Trying to build using 1.34.2 (the latest version available on Debian stable) yields the following error:

error[E0658]: use of unstable library feature 'alloc': this library is unlikely to be stabilized in its current form or name (see issue #27783)
  --> /home/alphare/.cargo/registry/src/github.com-1ecc6299db9ec823/miniz_oxide-0.4.0/src/lib.rs:28:1
   |
28 | extern crate alloc;
   | ^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: Could not compile `miniz_oxide`.
warning: build failed, waiting for other jobs to finish...
error: build failed

Looking at the code, there does not seem to be a feature flag guarding the extern crate alloc statement, making this crate at least compatible with 1.36+, not 1.34, which is a bummer.

Looking into the issues and PRs it seems that #84 would fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants