Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor visual bug in The People section on the Team page #141

Closed
n-d-r-d-g opened this issue Jun 8, 2024 · 1 comment
Closed

Minor visual bug in The People section on the Team page #141

n-d-r-d-g opened this issue Jun 8, 2024 · 1 comment

Comments

@n-d-r-d-g
Copy link
Contributor

Hi,

I noticed a bug in The People section, where people with no link to their speaker page are shifted slightly upwards (see screenshot: red line shows the alignment issue).
image

I think it can be fixed by removing the space-y-4 class on the NuxtLink and div wrapping the image:

<NuxtLink :href="`/speaker/${person.id}`">
  <span class="sr-only hidden">{{ person.name }}</span>
  <img ... />
  ...
</NuxtLink>
...
<div>
  <img ... />
  ...
</div>

image
@n-d-r-d-g n-d-r-d-g mentioned this issue Jun 9, 2024
Merged
@n-d-r-d-g
Copy link
Contributor Author

n-d-r-d-g commented Jun 9, 2024 •
edited
Loading

I created a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrSunshyne @n-d-r-d-g