Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Pages #221

Merged
merged 2 commits into from
May 31, 2023
Merged

Scale Pages #221

merged 2 commits into from
May 31, 2023

Conversation

LaserKaspar
Copy link
Member

Page Scale & Simple Crop

image
image

What does this do?

It allows users to set a page size (e.g. A4) and a scale. The input document will then be scaled up/down as much as necessary to fit the new page size. After that the scale factor is applied.

Motivation

I needed to scale multiple PDFs by a factor of 1.2 while maintaining a page size of A4 to get rid of a white border around my PDFs. This change makes it possible, maybe this will help other people too!

Love your project (and your motivation) so far! Keep it up!

@Frooodle
Copy link
Member

Love the idea and thanks for contributing to Stirling PDF!

@Frooodle
Copy link
Member

I would change how the filename is done to use the Util package but i forgot to do that last commit you referred so my bad haha
Will do commit my side to fix that

@Frooodle Frooodle merged commit a43c296 into Stirling-Tools:main May 31, 2023
2 checks passed
@Frooodle
Copy link
Member

image

@LaserKaspar did minor changes and changed icon
15d3941
thanks again!

@Frooodle
Copy link
Member

Frooodle commented May 31, 2023

Might change description a bit though... to me this makes a a4 document 20% larger than a A4 document
Not that it scales the page contents while maintaining the a4 size and hence removing white borders etc

@LaserKaspar please correct me if my understanding isnt correct

@LaserKaspar
Copy link
Member Author

LaserKaspar commented May 31, 2023

It should create an A4 page and only scale the contents of the original PDF. So even if you enter 2x scale, wich in your example would result in an A3 page, it will still maintain the size of a A4 page. How would you change the description?

@Frooodle
Copy link
Member

Frooodle commented May 31, 2023

Yeah thats what i thought, i think we need to change description to better describe it scales contents not the page itself (title as that is fine though)

@LaserKaspar
Copy link
Member Author

How about:
"Change the size of page contents while maintaining a set page-size"

@Frooodle
Copy link
Member

Perfect

@Frooodle
Copy link
Member

Frooodle commented Oct 8, 2023

Hi LaserKaspar,

We are updating Stirling-PDF's license to MPL 2.0 (Mozilla Public License Version 2.0) to continue fostering our open-source commitment while introducing more flexible usage of the project.

What We Need From You:

In order to transition to the MPL 2.0 license, we need the explicit consent of all our contributors.

  1. If you're comfortable relicensing your contributions for this specific PR under MPL 2.0, please respond with:
    I, LaserKaspar, grant permission to relicense my contributions from this PR to Stirling-PDF under the Mozilla Public License 2.0.
  2. If you'd prefer to give blanket permission for all of your contributions to Stirling-PDF (be it through pull requests, commits, or any other form of contribution) rather than on a PR-by-PR basis, please respond with:
    I, LaserKaspar, grant permission to relicense all my contributions to Stirling-PDF under the Mozilla Public License 2.0.

What does this do and why?

As your old code was contributed under a different license it legally cannot move to a new license without your permission, and since we dont want to lose your code we wanted to reach out. Remember this project is remaining open-source!.

Deadline:

If we dont receive a response, or if you decline, unfortunately, we will have to remove your contributions from Stirling-PDF before the license change, which is scheduled in coming months.

Thank You!

Your contributions are invaluable, and we hope to continue having them in Stirling-PDF under the new license. Feel free to ask if you have any questions or concerns about this change.

Best,
Frooodle
Stirling-PDF Maintainer

1 similar comment
@Frooodle
Copy link
Member

Frooodle commented Oct 8, 2023

Hi LaserKaspar,

We are updating Stirling-PDF's license to MPL 2.0 (Mozilla Public License Version 2.0) to continue fostering our open-source commitment while introducing more flexible usage of the project.

What We Need From You:

In order to transition to the MPL 2.0 license, we need the explicit consent of all our contributors.

  1. If you're comfortable relicensing your contributions for this specific PR under MPL 2.0, please respond with:
    I, LaserKaspar, grant permission to relicense my contributions from this PR to Stirling-PDF under the Mozilla Public License 2.0.
  2. If you'd prefer to give blanket permission for all of your contributions to Stirling-PDF (be it through pull requests, commits, or any other form of contribution) rather than on a PR-by-PR basis, please respond with:
    I, LaserKaspar, grant permission to relicense all my contributions to Stirling-PDF under the Mozilla Public License 2.0.

What does this do and why?

As your old code was contributed under a different license it legally cannot move to a new license without your permission, and since we dont want to lose your code we wanted to reach out. Remember this project is remaining open-source!.

Deadline:

If we dont receive a response, or if you decline, unfortunately, we will have to remove your contributions from Stirling-PDF before the license change, which is scheduled in coming months.

Thank You!

Your contributions are invaluable, and we hope to continue having them in Stirling-PDF under the new license. Feel free to ask if you have any questions or concerns about this change.

Best,
Frooodle
Stirling-PDF Maintainer

@LaserKaspar
Copy link
Member Author

I, LaserKaspar, grant permission to relicense my contributions from this PR to Stirling-PDF under the Mozilla Public License 2.0.

Keep it up! (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants