Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malleable Blocks Part 2 #186

Merged
merged 11 commits into from Mar 2, 2022
Merged

Malleable Blocks Part 2 #186

merged 11 commits into from Mar 2, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Feb 23, 2022

Followup PR to #180 to address some feedback there.

Also found some issues with how block id's were handled, so I changed the execution flow a bit to only generate a block id after the MST is finalized.

fuel-core/src/model/fuel_block.rs Show resolved Hide resolved
fuel-core/src/model/fuel_block.rs Outdated Show resolved Hide resolved
fuel-core/src/model/fuel_block.rs Show resolved Hide resolved
fuel-core/src/executor.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments from me, will defer to @rakita

@adlerjohn adlerjohn requested a review from rakita March 1, 2022 21:15
@Voxelot Voxelot mentioned this pull request Mar 2, 2022
Copy link
Contributor

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Voxelot Voxelot merged commit 10a47d0 into master Mar 2, 2022
@Voxelot Voxelot deleted the malleable-block-pt2 branch March 2, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants