Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all occurrences of Error to FuelError #2001

Open
Tracked by #1556
petertonysmith94 opened this issue Apr 2, 2024 · 9 comments
Open
Tracked by #1556

Replace all occurrences of Error to FuelError #2001

petertonysmith94 opened this issue Apr 2, 2024 · 9 comments
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute p2 Low Priority

Comments

@petertonysmith94
Copy link
Contributor

Change all instances of new Error, and replace with a FuelError with an appropriate error code.

For context, please reference this issue.

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Apr 2, 2024
@arboleya arboleya added the good first issue Suitable for newcomers looking to contribute label Apr 8, 2024
@kartikey315
Copy link

Hey @petertonysmith94, I want to work on this issue please guide me.

@maschad
Copy link
Member

maschad commented Apr 18, 2024

Hey @kartikey315 thanks for your interest in taking this on!

Essentially there are some instances of the standard Error still being thrown which we would like to convert to our custom FuelError class with it's own set of error codes

Feel free to review our Contributing guide to get started.

@kartikey315
Copy link

Thanks @maschad. I will get started with this.

@petertonysmith94
Copy link
Contributor Author

Thank you @kartikey315!

@maschad
Copy link
Member

maschad commented May 6, 2024

Hey @kartikey315 have you been able to make any progress on this?

@arboleya arboleya added p0 High priority p1 Medium priority and removed p0 High priority labels Jun 9, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 12, 2024
@VedantGonnade
Copy link

Hey @petertonysmith94 I would like to work on this task.

@petertonysmith94
Copy link
Contributor Author

Hey @VedantGonnade, you're more than welcome to 😄

If you need a hand, then pop us a message - more than willing to assist.

@arboleya
Copy link
Member

@VedantGonnade I just noticed we already have an ongoing PR for this issue:

Please consider picking up another good first issue if you want. 🙂

Thank you for your interest in contributing to the project.

@mvares
Copy link
Contributor

mvares commented Jun 19, 2024

At the moment, I'm working to close this issue 💯

@arboleya arboleya added p2 Low Priority and removed p1 Medium priority labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore good first issue Suitable for newcomers looking to contribute p2 Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants