Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in binaries #2084

Closed
arboleya opened this issue Apr 17, 2024 · 5 comments · Fixed by #2143
Closed

Remove built-in binaries #2084

arboleya opened this issue Apr 17, 2024 · 5 comments · Fixed by #2143

Comments

@arboleya
Copy link
Member

arboleya commented Apr 17, 2024

Summary

  • Remove all built-in binaries (however, keep them for the internal SDK purposes only).
  • Favouring the fuelup toolchain (w/ forc and fuel-core) for the end-user prerequisites.
@arboleya
Copy link
Member Author

Turns out this page is not even shown in the current menu.

Although it exists and can be reached via links in other pages:

@petertonysmith94
Copy link
Contributor

@arboleya as well as removing the documentation references to these tools, I was thinking of the following:

  • Removing useBuiltinFuelCore and useBuiltinForc from fuels config.
    I believe forcBuildFlags still has an application.
  • Removing forc and core commands from Fuels CLI and making these internal scripts.

What do you think?

@arboleya
Copy link
Member Author

Agreed. 💯

We should also mark packages/{forc,fuel-core} packages as private: true.

They would still be available to the workspace via the fuels- prefix:

  • pnpm fuels-forc
  • pnpm fuels-core

The above should suffice for building contracts and running tests in CI, but the packages won't be published to NPM.

One key benefit of this change is that we will no longer have to deal with NPM post-install scripts, which can be considered a net positive for increased Bun support. cc @Dhaiwat10

@petertonysmith94
Copy link
Contributor

I was thinking of moving them into the internal/{forc,fuel-core} directory, and setting private: true.

Any thoughts on this?

@arboleya
Copy link
Member Author

Makes sense. 👍

@petertonysmith94 petertonysmith94 changed the title Consider un-documenting built-in binaries Remove built-in binaries May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants