Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workflow to validate version bumps #2244

Closed
arboleya opened this issue May 6, 2024 · 3 comments · Fixed by #2275
Closed

Add new workflow to validate version bumps #2244

arboleya opened this issue May 6, 2024 · 3 comments · Fixed by #2275
Assignees
Labels

Comments

@arboleya
Copy link
Member

arboleya commented May 6, 2024

Before we hit stable v1, our semver requires a slight shift:

  • major — never (for now)
  • minor — when we introduce a breaking change
  • patch — everything else (non-breaking)

This has been a source of misunderstanding on several PRs, something a simple workflow could automate.

One way to do this is to only allow minor bumps when the PR has breaking changes (look for ! in the title).

@arboleya arboleya added the chore label May 6, 2024
@maschad
Copy link
Member

maschad commented May 6, 2024

This could be perhaps provide a good short-term fix till we release our major.

One way to do this is to only allow minor bumps when the PR has breaking changes (look for ! in the title).

I assume we would also allow minor bumps for feats as well?

@arboleya
Copy link
Member Author

arboleya commented May 6, 2024

No, minor must be reserved for breaking changes only, mimicking what would be a major bump.

@arboleya
Copy link
Member Author

arboleya commented May 8, 2024

Sometimes, we may mix patch with minor.

Please, refer to this comment for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants