Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to use local fuels build #834

Closed
arboleya opened this issue Mar 16, 2023 · 1 comment
Closed

Make it possible to use local fuels build #834

arboleya opened this issue Mar 16, 2023 · 1 comment
Assignees

Comments

@arboleya
Copy link
Member

arboleya commented Mar 16, 2023

Currently, on all package.json we have, we export Typescript files:

"exports": {
  ".": "./src/index.ts",
  "./cli": "./src/cli.ts",
  "./runTypegen": "./src/runTypegen.ts"
}

While this enabled a seamless go to definition experience in VSCode, it prohibits using the packages locally.

Let's say I'm building an app.

  • I add my local fuels as a dependency and re-run my app
  • My app requires the package fuels expecting to receive Javascript
  • Due to our configs (json above), it receives Typescript
  • Nothing works now

Goals we're looking for:

  1. Keep go to definition feature working as is
    • Developer workflow continues to be awesome
  2. While exporting compiled version of the package
    • So it can be used anywhere

The solution relies (edit: may rely) on: declarationMap

@arboleya arboleya self-assigned this Mar 16, 2023
@arboleya arboleya changed the title Make it possible to use local fuels Make it possible to use local fuels build Mar 16, 2023
@arboleya
Copy link
Member Author

This has already been done in multiple follow-up PR after #827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant