Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check that the symbol import is public. #5124

Open
esdrubal opened this issue Sep 18, 2023 · 1 comment
Open

Missing check that the symbol import is public. #5124

esdrubal opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
compiler General compiler. Should eventually become more specific as the issue is triaged

Comments

@esdrubal
Copy link
Contributor

We should fix the todo message in:

// TODO: check that the symbol import is public?
self.resolve_symbol(handler, src_path, true_symbol)

          Is this still TODO?

Originally posted by @IGI-111 in #5048 (comment)

@esdrubal esdrubal self-assigned this Sep 18, 2023
@esdrubal esdrubal added the compiler General compiler. Should eventually become more specific as the issue is triaged label Sep 18, 2023
@jjcnn jjcnn self-assigned this Jul 2, 2024
@jjcnn
Copy link
Contributor

jjcnn commented Jul 2, 2024

root.rs has been changed quite a lot since the commit that contains the quoted code snippet, so the fix requires a little bit more than just a simple visibility check.

As I mentioned on slack I've got some tests for this exact issue that I've had to disable because our path resolution is broken. I suggest we fix this one as part of the fix for path resolution, which is the next thing I'll be looking at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

No branches or pull requests

2 participants