New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The compiler checks for exhaustive match arms in match expressions. #701
Merged
emilyaherbert
merged 65 commits into
master
from
emilyaherbert-581/exhaustive-pattern-matches
Mar 22, 2022
Merged
The compiler checks for exhaustive match arms in match expressions. #701
emilyaherbert
merged 65 commits into
master
from
emilyaherbert-581/exhaustive-pattern-matches
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing variables prefixing the expression itself.
sezna
reviewed
Feb 3, 2022
…xhaustive-pattern-matches
mohammadfawaz
added
enhancement
New feature or request
compiler
General compiler. Should eventually become more specific as the issue is triaged
labels
Mar 15, 2022
Pinging @canndrew @sezna @mohammadfawaz @otrho for review 😄 |
Just one question, then I'm ready to approve: #701 (comment) |
sezna
previously approved these changes
Mar 19, 2022
sezna
previously approved these changes
Mar 20, 2022
adlerjohn
reviewed
Mar 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @otrho won the merge conflict race
….com:FuelLabs/sway into emilyaherbert-581/exhaustive-pattern-matches
Pinging @canndrew @sezna @mohammadfawaz @otrho for review 😄 |
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
sezna
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler
General compiler. Should eventually become more specific as the issue is triaged
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #581
This PR does two things:
sway-core/src/semantic_analysis/ast_node/expression/usefulness/mod.rs
. Let me know if you have questions 😄