Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes #430

Closed
9 tasks done
brozorec opened this issue Apr 4, 2023 · 2 comments
Closed
9 tasks done

UI fixes #430

brozorec opened this issue Apr 4, 2023 · 2 comments
Assignees

Comments

@brozorec
Copy link
Contributor

brozorec commented Apr 4, 2023

Based on @Markoyw feedback, here are some bug fixes, mainly on the UI side.

  • For more information, check the comments in Figma on each screen.

  • Start a new branch from "frontend/fix/internal-v2-testing" if it's not already merged in "main".

  • align icons of providers: link

  • edit tx modal according designs: link and link

  • edit tx modal: close button (+ handle mobile clipping)

  • edit tx modal: image sizes

  • edit tx modal: text overlapping (works with aave, compound not)

  • edit tx modal: add token bottom margin too big

  • edit tx modal: add token color

  • in borrow's button comp, don't show "withdrawing" etc but "processing" for all

  • set fixed height background in my-positions: link

@brozorec brozorec mentioned this issue Apr 4, 2023
26 tasks
@ferostabio
Copy link
Contributor

What is the Validate Transaction step in the transaction modal @brozorec ? Because we just changed the bridge step to show destination data since everyone was confused about it.

@brozorec
Copy link
Contributor Author

brozorec commented Apr 6, 2023

What is the Validate Transaction step in the transaction modal @brozorec ? Because we just changed the bridge step to show destination data since everyone was confused about it.

It's just wording, we can ignore it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants