Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove whitelisting comments #121

Closed
benface opened this issue Aug 14, 2018 · 2 comments
Closed

Add option to remove whitelisting comments #121

benface opened this issue Aug 14, 2018 · 2 comments

Comments

@benface
Copy link
Contributor

benface commented Aug 14, 2018

Would it be possible to add an option to remove these comments after they are processed?

/*! purgecss ignore */
/*! purgecss start ignore */
/*! purgecss end ignore */

I am using Laravel-Mix which already cleans comments in production mode, but I have to add a ! at the beginning of the above comments (clean-css calls those "special comments") to prevent them from being removed before PurgeCSS has a chance to see them.

@Ffloriel
Copy link
Member

Yes, I think this should be the default behavior as those comments are not necessary after PurgeCSS did his work.

@benface
Copy link
Contributor Author

benface commented Sep 2, 2018

Yeah, I didn't want to suggest changing the default behaviour, but I agree; in fact I don't think it needs to be an option at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants