Embeds best-scheduled-tweets lib into code #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed babel and webpack and jest * bumped aws version again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
best-scheduled-tweetswas originally created with the intent to be a more generic and decoupled library to extract past tweets, but in reality, it got more and more bespoke and bloated to adapt to the needs of this project. Therefore, it doesn't make to much sense to keep maintaining it as a separate library.In fact, it is just extra effort to maintain it as a separate library because every change to it requires a new version to be published just to update this project.
This PR brings the library back into this repo.
Since the library used StandardJS (and this is now my preferred style), this PR also migrates all the pre-existing codebase to standardJS.
Note that this PR also removes the Hootsuite filter.
Once this PR is merged, a deprecation notice will be issued in the
best-scheduled-tweetlibrary on NPM (and on the repo README)