Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty hash when a metric returns empty array #32

Closed
wants to merge 1 commit into from

Conversation

kangkyu
Copy link
Contributor

@kangkyu kangkyu commented Jul 18, 2018

Sometimes I experience edge cases, once I found we received an empty array for page_fans_gender_age metric when fetch it from a small and new Facebook page. And current code returns nil in that case, that's probably not what we want.

For example, empty array for page_fans_gender_age metric
@coveralls
Copy link

Coverage Status

Coverage decreased (-26.4%) to 71.652% when pulling e6971c2 on kangkyu:empty_array_empty_hash into ef8d34d on Fullscreen:master.

@kangkyu
Copy link
Contributor Author

kangkyu commented Jul 20, 2018

https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings you need set encrypted env variables in travis.yml file to use them in pull requests from fork.

I'll close this and reopen another pull request from origin.

@kangkyu kangkyu closed this Jul 20, 2018
@kangkyu kangkyu deleted the empty_array_empty_hash branch July 20, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants