Funky::Video.where(id: id) should never error.
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if a single video id was passed into Funky::Video.where, and that video could not be accessed, it would raise ContentNotFound. That goes against the readme and is not consistent with when we pass multiple ids to the where clause. The where clause should simply ignore badd video ids. If it's a single video id, it should return and empty array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a single video id was passed into Funky::Video.where,
and that video could not be accessed, it would raise ContentNotFound.
That goes against the readme and is not consistent with when we pass
multiple ids to the where clause. The where clause should simply
ignore badd video ids. If it's a single video id, it should return
and empty array.