Find page name the video is from #48

kangkyu · 2016-06-22T16:36:08Z

Funky::Video.where(id: '203203106739575').first.page_name
# => "This Is Us"

close #46

claudiofullscreen · 2016-06-22T16:38:03Z

lib/funky/video.rb

@@ -40,6 +40,11 @@ def picture
      data[:picture]
    end

+    # @return [String] the name of Facebook page for the video.
+    def page_name
+      data.dig(:from, :name)


This is 🆗

However this method has been added to recent versions of Ruby, so if we go with this code, we should add the required Ruby version both to the README and to the .gemspec file.

@philipqnguyen Are you okay with not supporting older versions of Ruby?

Maybe we should fetch?

I'll make a new PR from "not fork" (because travis..) and fix that too (use instead fetch)

It's up to you 🎱

coveralls · 2016-06-22T16:41:18Z

Coverage decreased (-4.5%) to 95.472% when pulling 401a139 on kangkyu:title_where into e421f8f on Fullscreen:master.

Add page_name attribute for a video from API call

401a139

claudiofullscreen reviewed Jun 22, 2016
View reviewed changes

kangkyu closed this Jun 22, 2016

kangkyu deleted the title_where branch June 22, 2016 17:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Find page name the video is from #48

Find page name the video is from #48

kangkyu commented Jun 22, 2016

claudiofullscreen Jun 22, 2016

philipqnguyen Jun 22, 2016

kangkyu Jun 22, 2016 •

edited

claudiofullscreen Jun 22, 2016

coveralls commented Jun 22, 2016

Find page name the video is from #48

Find page name the video is from #48

Conversation

kangkyu commented Jun 22, 2016

claudiofullscreen Jun 22, 2016

Choose a reason for hiding this comment

philipqnguyen Jun 22, 2016

Choose a reason for hiding this comment

kangkyu Jun 22, 2016 • edited

Choose a reason for hiding this comment

claudiofullscreen Jun 22, 2016

Choose a reason for hiding this comment

coveralls commented Jun 22, 2016

kangkyu Jun 22, 2016 •

edited