Add since option to Page#posts and Page#videos #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiofullscreen
suggested changes
Jul 27, 2017
lib/funky/page.rb
Outdated
| def videos(options = {}) | ||
| path_query = "#{id}/videos?fields=id,title,description,created_time,length,comments.limit(0).summary(true),likes.limit(0).summary(true),reactions.limit(0).summary(true)" | ||
| path_query << "&since=#{options[:since]}" if options[:since] | ||
| videos = Funky::Connection::API.fetch_all(path_query) |
There was a problem hiding this comment.
@kangkyu The is_array: true part is missing.
There was a problem hiding this comment.
I used fetch_all instead of fetch method for token-based pagination. I thought time-based pagination (fetch with is_array: true) can be hard to work with since or until parameter
| @@ -46,8 +46,10 @@ def videos | |||
| # | |||
| # @return [Array<Funky::Post>] multiple Funky::Post objects containing data | |||
| # fetched by Facebook Graph API. | |||
| def posts | |||
| posts = Funky::Connection::API.fetch_all("#{id}/posts?fields=type,created_time") | |||
| def posts(options = {}) | |||
|
closing in favor of #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.