Delete playlist items via content owner #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkyu
reviewed
Feb 6, 2020
| @@ -101,6 +101,12 @@ def resource_id | |||
| {kind: 'youtube#video', videoId: video_id} | |||
| end | |||
|
|
|||
| def delete_params | |||
| super.tap do |params| | |||
| params[:params].merge! @auth.playlist_items_params | |||
There was a problem hiding this comment.
I think method name playlist_items_params can be different? Actually it is used in collections file
https://github.com/Fullscreen/yt/blob/master/lib/yt/collections/playlist_items.rb#L44
How about playlist_item_params
There was a problem hiding this comment.
We chatted about this offline, but for the viewers at home: delete_params is invoked by the Delete action when you call do_delete, and it has a default implementation (hence the super).
kangkyu
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.