Update video via content owner #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgb
reviewed
Feb 6, 2020
lib/yt/models/video.rb
Outdated
| # @see https://developers.google.com/youtube/v3/docs/videos/update | ||
| def update_params | ||
| super.tap do |params| | ||
| params[:params] = {on_behalf_of_content_owner: auth.owner_name} if auth.owner_name |
There was a problem hiding this comment.
What do you think about extending the pattern we have and adding video_params to ContentOwner and Account. That way this doesn't need to know or care what auth is, and can just look something like:
def update_params
super.tap do |params|
params[:params].merge!(auth.video_params)
end
endThere was a problem hiding this comment.
Unrelated but params[:params] can be nil so we can params[:params] ||= {}
dgb
approved these changes
Feb 7, 2020
kangkyu
force-pushed
the
co-video-update
branch
from
c8341c0
to
6f014d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.