Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recovery] Inconsistent and misleading wording in the menu #14

Closed
DrUm78 opened this issue Apr 23, 2021 · 3 comments
Closed

[Recovery] Inconsistent and misleading wording in the menu #14

DrUm78 opened this issue Apr 23, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@DrUm78
Copy link

DrUm78 commented Apr 23, 2021

Wording is inconsistent and misleading in Recovery menu. Indeed "FIRST BOOT DISABLE" is by default and means here that it's disabled and that you have to click to enable it. Regarding "FACTORY TESTS ENABLE" it's the contrary: it's here disabled too and you have to click to enable it whereas the wording is the opposite, that's very confusing and we should differentiate the state of an option and the action it performs when clicking it. As an example, I myself misclicked one or two times and triggered the FIRST BOOT sequence by mistake.
Tested on firmwares 2.0.0, 2.0.1, 2.1.0, 2.1.1 beta, 2.2.0 beta.

Steps to reproduce the behavior:

  1. Press Fn+START while booting the device
  2. Once in Recovery menu, use UP or DOWN d-pad to select menu
  3. Notice the the inconsistency between "FACTORY TESTS ENABLE", "FIRST BOOT DISABLE" and "NETWORK ENABLE"

Expected behavior
By default, you should have the different options like this:
ENABLE FACTORY TESTS => DISABLE FACTORY TESTS
ENABLE FIRST BOOT => DISABLE FIRST BOOT
ENABLE NETWORK => DISABLE NETWORK
or
FACTORY TESTS: DISABLED => FACTORY TESTS: ENABLED
FIRST BOOT: DISABLED => FIRST BOOT: ENABLED
NETWORK: DISABLED => NETWORK: ENABLED

Note: I personally prefer the 2nd one, more natural as that's easier to understand the current status of each option.

Screenshots
first_boot_disable factory_tests_enable

@DrUm78 DrUm78 changed the title Inconsistent and misleading wording in Recovery menu [Recovery] Inconsistent and misleading wording in the menu Apr 23, 2021
@Michel-FK
Copy link
Contributor

The second option is definitely clearer!

@Michel-FK Michel-FK added the enhancement New feature or request label Apr 28, 2021
@Michel-FK Michel-FK self-assigned this Apr 28, 2021
@Michel-FK
Copy link
Contributor

Corrected with commit 50d8df9

@DrUm78
Copy link
Author

DrUm78 commented May 15, 2021

Fixed in verified (I managed to update my "mmcblk0p1" partition without opening my console again)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants