Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pyclipper -> pyclipr #3375

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

feat: pyclipper -> pyclipr #3375

wants to merge 8 commits into from
+247 −9

Conversation

oliverfunk
Copy link
Contributor

@oliverfunk oliverfunk commented Jun 18, 2024 •
edited
Loading

Linked Issues

Closes #3197

Description

Moves to the new pyclipr package based on Clipper2 for the fallback offsetting library.

Interface Changes

None, only internal api's.

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@oliverfunk oliverfunk marked this pull request as ready for review June 19, 2024 12:17
@oliverfunk oliverfunk requested a review from a team as a code owner June 19, 2024 12:17
@oliverfunk
Copy link
Contributor Author

oliverfunk commented Jun 19, 2024 •
edited
Loading

3 problems:

  • Seemingly cannot set Miter limit
  • The accuracy of the returned offset no longer passes the "isclose" checks unless the precision is reduced
  • Pclippr does not return None for invalid geometry, it no longer fails, which means one of the tests fails because of it

also:
The docs need to be updated
Dep needs to be added

@je-cook
Copy link
Contributor

je-cook commented Jun 24, 2024

Cool! how do you feel about the package, good change?

@je-cook je-cook added geometry Tasks relating to the geometry module enhancement New feature or request labels Jun 24, 2024
@je-cook je-cook self-assigned this Jun 26, 2024
@oliverfunk oliverfunk force-pushed the oliverfunk/3197-Look-into-clipper-2-and-pyclipr-as-a-pyclipper-upgrade branch from 8a2ec75 to d6dc520 Compare June 28, 2024 15:19
@oliverfunk oliverfunk requested a review from a team as a code owner June 28, 2024 15:19
@oliverfunk
Copy link
Contributor Author

I've realised after testing, this seemingly cannot do negative offsets.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@oliverfunk oliverfunk marked this pull request as draft July 1, 2024 10:31
@je-cook je-cook removed their assignment Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request geometry Tasks relating to the geometry module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Look into clipper 2 and pyclipr as a pyclipper upgrade
2 participants
@oliverfunk @je-cook