[bug] Incorrect change detection for application form configuration

[elliotdickison]

Description

If you include form_configuration on a fusionauth_application resource without specifying an admin registration form ID then Terrform will report that the admin registration form ID has changed on every apply.

Reproduce

# On every apply you'll see something like: - admin_registration_form_id = "8369bc8a-5be8-02b9-7f2d-cd869c09a57b"
resource "fusionauth_application" "this" {
  
  ...

  form_configuration {
    self_service_form_id = "f8f406ba-8810-47c8-a984-3ab4a43eaf59"
  }
}

Workaround

I can't figure out a way to ignore changes to the admin_registration_form_id field without also ignoring changes to the self_service_form_id field - there's something odd with the way form_configuration is handled in a lifecycle.ignore_changes block (adding form_configuration["admin_registration_form_id"] results in an error).

For now I'm just explicitly setting admin_registration_form_id to the default form any time I need to use the form_configuration block (fusionauth_form data source to the rescue):

data "fusionauth_form" "default_admin_registration" {
  name = "Default Admin Registration provided by FusionAuth"
}

resource "fusionauth_application" "this" {
  
  ...

  form_configuration {
    admin_registration_form_id = data.fusionauth_form.default_admin_registration.id
    self_service_form_id = "f8f406ba-8810-47c8-a984-3ab4a43eaf59"
  }
}