Making executor mark pods that are unrecoverably stuck sooner #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a pod is submitted with something that causes it to get "stuck" (i.e stay in Pending but Kubernetes doesn't consider it a failure), users must with the full stuckPodExpiry before Armada does anything about it. However some reasons pods get stuck are never going to recover (invalid mount path, invalid image name etc). Now the executor will try to spot these unrecoverable situations and return this error back to the user sooner, rather than waiting the whole stuckPodExpiry.
jankaspar
previously approved these changes
Jun 30, 2021
internal/executor/util/pod_status.go
Outdated
| func hasUnpullableImageEvent(podEvents []*v1.Event) (bool, *v1.Event) { | ||
| for _, event := range podEvents { | ||
| if event.Type == v1.EventTypeWarning && strings.HasPrefix(event.Message, failedPullPrefix) { | ||
| // Failed to pull image "alpine:latst": rpc error: code = NotFound desc = failed to pull and unpack image "docker.io/library/alpine:latst": failed to resolve reference "docker.io/library/alpine:latst": docker.io/library/alpine:latst: not found |
There was a problem hiding this comment.
Should the comments be left here?
jankaspar
approved these changes
Jun 30, 2021
ljubon
pushed a commit
to ljubon/armada
that referenced
this pull request
Jul 1, 2021
…project#617) * Making executor mark pods that are unrecoverably stuck sooner Currently if a pod is submitted with something that causes it to get "stuck" (i.e stay in Pending but Kubernetes doesn't consider it a failure), users must with the full stuckPodExpiry before Armada does anything about it. However some reasons pods get stuck are never going to recover (invalid mount path, invalid image name etc). Now the executor will try to spot these unrecoverable situations and return this error back to the user sooner, rather than waiting the whole stuckPodExpiry. * Simplify logic * Remove commented code
ljubon
pushed a commit
to ljubon/armada
that referenced
this pull request
Jul 1, 2021
…project#617) * Making executor mark pods that are unrecoverably stuck sooner Currently if a pod is submitted with something that causes it to get "stuck" (i.e stay in Pending but Kubernetes doesn't consider it a failure), users must with the full stuckPodExpiry before Armada does anything about it. However some reasons pods get stuck are never going to recover (invalid mount path, invalid image name etc). Now the executor will try to spot these unrecoverable situations and return this error back to the user sooner, rather than waiting the whole stuckPodExpiry. * Simplify logic * Remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a pod is submitted with something that causes it to get "stuck" (i.e stay in Pending but Kubernetes doesn't consider it a failure), users must with the full stuckPodExpiry before Armada does anything about it.
However some reasons pods get stuck are never going to recover (invalid mount path, invalid image name etc).
Now the executor will try to spot these unrecoverable situations and return this error back to the user sooner, rather than waiting the whole stuckPodExpiry.