Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uid range partitioning fast #32

Closed
EnricoMi opened this issue Jul 9, 2020 · 0 comments · Fixed by #34
Closed

Make uid range partitioning fast #32

EnricoMi opened this issue Jul 9, 2020 · 0 comments · Fixed by #34
Labels
enhancement New feature or request

Comments

@EnricoMi
Copy link
Collaborator

EnricoMi commented Jul 9, 2020

Uid Partitioning uses Dgraph's GraphQl operation offset, which is very slow on large result sets (see issue #5808). The alternative after has constant response time. Remove the offset related pagination used for partitioning and use the chunked reading that is based on after.

This removes the count uid range estimator (because count is also slow, see issue #5813) and any offset related code from PartitionQuery.

If at some point count and offset become efficient, we can resurrect this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant