IP-56: Compare image by dragging the slider at the bottom (also you can save it) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 9, 2021 18:04
…ssed and original image.
…ntil slider moves
…me transparent when mouse not hovering?) and go back to the rightmost when each transform performed
Add slider initial function so everytime an operation (filter, colouring, import image, etc.) should set the slider back to the initial position.
mihane-ichinose
commented
Nov 13, 2021
| @@ -143,6 +189,10 @@ class EngineModel( | |||
| ) | |||
| Adjustment(adjustmentProperties).process(preview) | |||
| previewImage.value = preview | |||
| parallelImage.value = previewImage.value | |||
There was a problem hiding this comment.
I added this line to the end of each function so the imageview updates after every picture process. Now I use update slider sliderInit() and the value of the parallelImage should also change as the slider value binds with it. So I believe this line could be removed?
|
Example below: |
JoeyTeng
approved these changes
Nov 13, 2021
| fun loadEncodeImage(path: String) { | ||
| val image = Image(path) | ||
| encodeImage.value = image | ||
| } | ||
|
|
||
There was a problem hiding this comment.
shall we remove this spaces...?
…G into IP56-slider-image-comparison
mihane-ichinose
added a commit
that referenced
this pull request
Nov 14, 2021
fix(slider-with-spinner): NPE: issue introduced in #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export parallelto save in current state.Some improvements can have in the future: