Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider-with-spinner): NPE: issue introduced in #33 #37

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

JoeyTeng
Copy link
Contributor

@JoeyTeng JoeyTeng commented Nov 14, 2021

NPE when user delete number in any spinner in filter tabs (like RGB)

Introduced in f3b073f in #33
Should use doubleSpinner the factored out component rather than raw spinner

@JoeyTeng JoeyTeng added the bug Something isn't working label Nov 14, 2021
@JoeyTeng JoeyTeng added this to the Iteration 3 milestone Nov 14, 2021
@JoeyTeng JoeyTeng changed the title fix(slider-with-spinner): NPE: issue introduced in fb25fa43ee989728d7be43 fix(slider-with-spinner): NPE: issue introduced in f3b073f83ae7436773fb25fa43ee989728d7be43 Nov 14, 2021
@JoeyTeng JoeyTeng changed the title fix(slider-with-spinner): NPE: issue introduced in f3b073f83ae7436773fb25fa43ee989728d7be43 fix(slider-with-spinner): NPE: issue introduced in #33 Nov 14, 2021
@mihane-ichinose
Copy link
Contributor

The issue is now fixed

@mihane-ichinose mihane-ichinose merged commit b98207b into develop Nov 14, 2021
@mihane-ichinose mihane-ichinose deleted the FIX-spinner-NPE branch November 14, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants