Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import image #4

Closed
wants to merge 11 commits into from
Closed

Import image #4

wants to merge 11 commits into from

Conversation

mihane-ichinose
Copy link
Contributor

@mihane-ichinose mihane-ichinose commented Oct 13, 2021

  • Added a button Open.. to let user browse which image they want to open in the main GUI window
  • Added a new fragment class ImportImage so a window will pop up when Open.. is clicked
  • The new window has a textfield to allow user input file path directly or by selecting files from clicking browse.. button on the right, then press OK button to commit
  • The file selector popped up from browse.. button now supports *.png, *.bmp, *.jpeg and *.jpg file extension (can be extended later)
  • Added try.. except.. block to handle exceptions if file path is invalid or image failed to open

@JoeyTeng
Copy link
Contributor

Should be merged after #3

src/main/kotlin/GUI.kt Outdated Show resolved Hide resolved
@danieldeng2
Copy link
Contributor

Please leave a description next time.

could you reformat the code back to kotlin official? thanks.

@hoangvu01 has set that up in gradle.

Shitian Jin added 2 commits October 14, 2021 10:01
…mageView' in GUI class, use inject() to other classes
…ath or url can now use the same function, move try except block from button action to controller for clearer MVC design. Also allow user to type in url from text field
@mihane-ichinose
Copy link
Contributor Author

Please leave a description next time.

could you reformat the code back to kotlin official? thanks.

@hoangvu01 has set that up in gradle.

Thanks for telling me, I now applied the Kotlin coding convention. Looks like it doesn't change compare to the previous version (Google Java Style) so I will not make another push.

@hoangvu01
Copy link
Contributor

I dont think you want to merge into master here

@mihane-ichinose
Copy link
Contributor Author

I dont think you want to merge into master here

Ohf... is there a way I can change the branch I merge to? Or else I'm gonna cancel this PR and open another one

@mihane-ichinose mihane-ichinose changed the base branch from master to develop October 14, 2021 08:21
@mihane-ichinose
Copy link
Contributor Author

No worry I found the setting..

@zhao-xuan zhao-xuan closed this Oct 16, 2021
@zhao-xuan zhao-xuan deleted the import-image branch October 16, 2021 10:42
@JoeyTeng JoeyTeng added this to the Iteration 1 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants