-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Refactor - Project Structure #9
Conversation
@xu-shitong I don't really get your pipeline. Say, you have this pipeline |
I remove the previous GrayScale so that when user click on the grayscale again(the grayscale box is not selected), the operation will be removed from the pipeline and the image is not in gray. if it is a |
I think the structure is fine! We should decide on what to do together as a group first so people's changes don't overlap in the future. |
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, great idea here, so basically just swap pixels in the same loop in one go and no clone is needed.
Major Project Refactor
Moved ALL functionalities/features to
EngineModel
which performs all logical operations for the image engine.Controllers
from now on should only handle Events and then call appropriate methods in the model.Note that there can be more than 1 model and more than 1 controller as long as their functions do not overlap (see
PAC
orHMVC
patterns).WIP