Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initialization parameters mandatory for Entity class #9

Open
G2Pavon opened this issue Jan 18, 2024 · 1 comment
Open

Make initialization parameters mandatory for Entity class #9

G2Pavon opened this issue Jan 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@G2Pavon
Copy link
Owner

G2Pavon commented Jan 18, 2024

Currently, the Entity class is initialized with Entity.__init__(self), which lacks specificity and might lead to incomplete entity initialization. Change the initialization to Entity.__init__(self, classname, origin_or_brushes, properties=None)
classname is fundamental for entities, and making it a requirement in the initialization helps ensure that entities are properly identified.
For point entities, origin is fundamental, while for brush entities brushes are. These parameters should be explicitly required during initialization to avoid incomplete entity states

@G2Pavon G2Pavon added the enhancement New feature or request label Jan 18, 2024
@G2Pavon
Copy link
Owner Author

G2Pavon commented Jan 20, 2024

now they are optional but not required: 59fc5cb

  • TODO: make them required (Requirements: Refactor load_map())

@G2Pavon G2Pavon changed the title Add initialization parameters for Entity class Make initialization parameters mandatory for Entity class Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant