Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BasisSmoother to accept irregularly sampled data #325

Open
vnmabus opened this issue Feb 22, 2021 · 1 comment
Open

Allow BasisSmoother to accept irregularly sampled data #325

vnmabus opened this issue Feb 22, 2021 · 1 comment

Comments

@vnmabus
Copy link
Member

vnmabus commented Feb 22, 2021

Is your feature request related to a problem? Please describe.
Currently, scikit-fda does not have any type for irregularly sampled data. A fully-fledged irregular type will require weeks or months of design and coding. However, if BasisSmoother could accept a list of FDataGrid as input, irregular data could be converted to a basis form as part of a pipeline.

Describe the solution you'd like
Implement BasisSmoother for lists of FDataGrid, at least until we have a proper type for irregular data.

Describe alternatives you've considered
A utility function could be provided instead, but it could not be used in a pipeline, which is important to adjust the hyperparameters.

Additional context
Irregularly sampled data arises in different contexts, such as in medicine. A way to convert this to a basis expansion in order to use FDA functionality would be useful for these use cases.

@vnmabus
Copy link
Member Author

vnmabus commented Oct 4, 2022

Some of the methods of BasisSmoother, such as the method to compute the hat matrix, make no sense in the sparse context. For now we can ignore it, but we will need to generalize that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant