Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gradient_criteria #524

Open
vnmabus opened this issue Mar 24, 2023 · 0 comments
Open

Rename gradient_criteria #524

vnmabus opened this issue Mar 24, 2023 · 0 comments

Comments

@vnmabus
Copy link
Member

vnmabus commented Mar 24, 2023

Currently the name gradient_criteria is used in the plot function to determine the values used to define a color gradient (e.g. the target values in regression, or the depth of the curves).

This name is not very good:

  • Syntactically, it is plural, when it should be singular (there is a single criterium).
  • This does not mention that it is a color gradient at all.

We should discuss alternatives and pick one, to change it. Ideally it should be coherent with the nomenclature in other Python packages. Current alternatives:

  • color_gradient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant