Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Event Actions #36

Merged
merged 29 commits into from May 7, 2020
Merged

[WIP] Event Actions #36

merged 29 commits into from May 7, 2020

Conversation

rdgain
Copy link
Collaborator

@rdgain rdgain commented Apr 16, 2020 •
edited

Implementation of Event actions, but:

TODO:

  • force action for Resilient Population (PandemicForwardModel.java)
  • GameState.java Forecast in partial observability should leave first N cards visible to player
  • actions spawned from Event cards should be free
  • should be able to play Event cards any time

This was linked to issues Apr 16, 2020
Event cards are not fully implemented as they require more complex checks #18
Closed
Add types that could distinguish Event cards from City cards. Could be useful in other games. #19
Closed
@rdgain rdgain linked an issue Apr 30, 2020 that may be closed by this pull request
Investigate Event system #41
Closed
@rdgain rdgain self-assigned this Apr 30, 2020
@rdgain
Copy link
Collaborator Author

rdgain commented Apr 30, 2020 •
edited

Rethinking forward model execution of rules, interruptions for reactions. A diagram of game flow in Pandemic to help with this:

Untitled Diagram (1)

@rdgain
Pandemic forward model rewritten as set of rules following diagram
6259667 
- could add further player reactions interleaved
@rdgain
Copy link
Collaborator Author

rdgain commented Apr 30, 2020 •
edited

Updated simplified diagram, reflected in pandemic FM rewrite as rules/conditions/game-over-conditions (although current code gets stuck in infinite loop...):

Untitled Diagram (2)

Legend:

  • rectangles = game rules
  • diamonds = conditions
  • blue = main rule in game flow
  • red = exceptional rule (not really treated any differently, but creates extra branch from normal game flow)
  • green = reactions triggered for current or other players
  • X = these states include game over condition checks and can trigger end of game

@rdgain rdgain mentioned this pull request May 6, 2020
Merged
@rdgain
Some more refactoring
28ad44c 
* turnStep - move to subclass, specialised
* endPlayerTurnStep in Game remove
* AbstractPlayer -> core package; id no modifier; Game constructor sets IDs for players
* setComponents in Game class
* .size on Deck
* generic constants, VERBOSE
* isPlayerAlive = playerResults
@rdgain rdgain merged commit 613eb48 into master May 7, 2020
@rdgain rdgain deleted the event-actions branch May 7, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADockhorn ADockhorn Awaiting requested review from ADockhorn

@diegopliebana diegopliebana Awaiting requested review from diegopliebana

@martinballa martinballa Awaiting requested review from martinballa

@montoliu montoliu Awaiting requested review from montoliu

Assignees

@rdgain rdgain

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rdgain