Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UseShed & UseCache Flags #105

Closed
doxthree opened this issue Oct 11, 2022 · 10 comments · Fixed by #259, #368 or #377
Closed

UseShed & UseCache Flags #105

doxthree opened this issue Oct 11, 2022 · 10 comments · Fixed by #259, #368 or #377
Labels
documentation Improvements or additions to documentation DotNet Pull requests that update DotNet code Java Pull requests that update Java code PHP Pull requests that update PHP code Python Pull requests that update Python code Rust Pull requests that update Rust code TypeScript Pull requests that update TypeScript code

Comments

@doxthree
Copy link
Contributor

doxthree commented Oct 11, 2022 •
edited

In the VerdictRequest protocol you can specify two optional flags:
use_shed & use_cache

These are debug flags and should be documented and provided as example in all SDKs.
@doxthree doxthree added the documentation Improvements or additions to documentation label Oct 11, 2022
@secana
Copy link
Member

secana commented Oct 11, 2022

Also, rename the use_shed to something different which describes what it is.

@secana
Copy link
Member

secana commented Oct 12, 2022 •
edited by unglaublicherdude

Flags implemented and documented as "only available for some accounts" in:

  • Rust
  • Dotnet
  • Java
  • PHP
  • Typescript
  • Python

@secana
Copy link
Member

secana commented Nov 28, 2022

@doxthree any progress on this one or is it not clear, if we need to implement it? I would rather keep the SDK simple and we decide how we protect the customer, instead of giving options.

@secana secana added TypeScript Pull requests that update TypeScript code PHP Pull requests that update PHP code DotNet Pull requests that update DotNet code Rust Pull requests that update Rust code Python Pull requests that update Python code Java Pull requests that update Java code labels Nov 28, 2022
@doxthree doxthree linked a pull request Jul 20, 2023 that will close this issue
java/105-useshed-usecache-flags #259
Merged
@doxthree doxthree reopened this Aug 11, 2023
@sfotiadis
Copy link
Contributor

UseShed renamed to UseHashLookup in go SDK

@unglaublicherdude unglaublicherdude linked a pull request Feb 22, 2024 that will close this issue
Php/105/useshed usecache flags #368
Merged
@unglaublicherdude
Copy link
Contributor

Pull Request for PHP is open.

@unglaublicherdude
Copy link
Contributor

Python already had the feature

@unglaublicherdude
Copy link
Contributor

Dotnet already had the feature

@unglaublicherdude
Copy link
Contributor

@secana any chance you can implement the flags for rus? 🥺

@secana
Copy link
Member

secana commented Feb 22, 2024

Sure. I'll have a look in the next few days.

@unglaublicherdude
Copy link
Contributor

dunno why I closed this, the rust pr is open now

@unglaublicherdude unglaublicherdude linked a pull request Feb 29, 2024 that will close this issue
Rust: implements the cache and hash-lookup flags #377
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation DotNet Pull requests that update DotNet code Java Pull requests that update Java code PHP Pull requests that update PHP code Python Pull requests that update Python code Rust Pull requests that update Rust code TypeScript Pull requests that update TypeScript code
Projects
None yet
Milestone
No milestone
4 participants
@secana @unglaublicherdude @doxthree @sfotiadis