Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Reminder Discord Bot #345

Merged
merged 13 commits into from Oct 21, 2021
Merged

Water Reminder Discord Bot #345

merged 13 commits into from Oct 21, 2021

Conversation

0xMukesh
Copy link
Contributor

Description

Added a new project to the scripts folder, Water Reminder Discord bot
Fixes #(issue number)

Type of change

  • New Script (non-breaking change which adds a new script to the repository)

Has This Been Tested?

  • I confirm that I have tested my script locally and verified that it works as intended.

Screenshot (if applicable)

image

image

Checklist:

  • I have gone through the contributing guidelines before making this Pull Request.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@0xMukesh 0xMukesh mentioned this pull request Oct 20, 2021
2 tasks
@OBITORASU
Copy link
Contributor

Can you port this as a basic python script which does the same and runs in the background instead of making it a specialty discord bot because that certainly limits the usability of this script? On top of that add a requirements.txt and some documentation in the form of a proper readme.

@0xMukesh
Copy link
Contributor Author

Can you port this as a basic python script which does the same and runs in the background instead of making it a specialty discord bot because that certainly limits the usability of this script?

Uh... I guess there is a water reminder python script already 😅

On top of that add a requirements.txt and some documentation in the form of a proper readme.

I will add it right now 🙂

@OBITORASU
Copy link
Contributor

Can you port this as a basic python script which does the same and runs in the background instead of making it a specialty discord bot because that certainly limits the usability of this script?

Uh... I guess there is a water reminder python script already sweat_smile

You can port your main.py as a normal locally run python script instead of turning it into a discord bot. As for the water reminder script being already present in our repository, I can't recall can you link me to it?

@0xMukesh
Copy link
Contributor Author

Can you port this as a basic python script which does the same and runs in the background instead of making it a specialty discord bot because that certainly limits the usability of this script?

Uh... I guess there is a water reminder python script already sweat_smile

You can port your main.py as a normal locally run python script instead of turning it into a discord bot. As for the water reminder script being already present in our repository, I can't recall can you link me to it?

Ohh shoot!!
I was checking my fork where I named the folder for the water reminder discord bot script as water reminder so I got confused
My bad

I will work on the local water reminder python script 👍

@0xMukesh
Copy link
Contributor Author

@OBITORASU 👍 I have made it into local python script

@OBITORASU
Copy link
Contributor

Looks good, make sure the lint checks pass and add this script to main readme.

@0xMukesh
Copy link
Contributor Author

Looks good, make sure the lint checks pass and add this script to main readme.

Oh ok 👍

@0xMukesh
Copy link
Contributor Author

Looks good, make sure the lint checks pass and add this script to main readme.

Added the script to the main readme

@OBITORASU
Copy link
Contributor

Last step make sure the lint checks pass.

@0xMukesh
Copy link
Contributor Author

Last step make sure the lint checks pass.

😅 sorry i am new to open source community, just started contributing this week
so idk anything about lint sorry
could you guide me about this?

@OBITORASU
Copy link
Contributor

Always read contributing guidelines I had mentioned how to make sure lint checks pass in there. Regardless, do the following, pip install black followed by black ., black will do autolinting for you just stage the changes and commit :)

@0xMukesh
Copy link
Contributor Author

Always read contributing guidelines I had mentioned how to make sure lint checks pass in there. Regardless, do the following, pip install black followed by black ., black will do autolinting for you just stage the changes and commit :)

Oh thanks a lot!

@OBITORASU OBITORASU merged commit 3cb6498 into GDSC-RCCIIT:main Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants