Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GermanGenderSwap Violates Naming Convention #310

Closed
boyleconnor opened this issue Oct 6, 2021 · 2 comments
Closed

GermanGenderSwap Violates Naming Convention #310

boyleconnor opened this issue Oct 6, 2021 · 2 comments

Comments

@boyleconnor
Copy link
Contributor

boyleconnor commented Oct 6, 2021 •
edited

Our transformation packages so far have all been in snake_case. @raft001, I believe this is your transformation. Could you change this, please?
@raft001 raft001 mentioned this issue Oct 7, 2021
Merged
@raft001
Copy link
Contributor

raft001 commented Oct 7, 2021

@cascadianblue , Yes, that was an oversight on my part. I have made a new pull-request to fix this, the original one can be removed.

@Saad-Mahamood Saad-Mahamood mentioned this issue Oct 8, 2021
Closed
@kaustubhdhole
Copy link
Collaborator

Fixed in #312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boyleconnor @kaustubhdhole @raft001