Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update select_unique_ngs() to get unique NGS reports at the dx level as opposed to the pt level #84

Open
jalavery opened this issue Oct 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jalavery
Copy link
Collaborator

jalavery commented Oct 26, 2022

select_unique_ngs() is currently based on selecting a unique NGS per patient (among the diagnoses subset on cohort_ngs), which is almost always going to be the structure of the diagnosis dataset returned from create_analytic_cohort(), so this is perfect for now. It is technically possible for someone to pull multiple cancer diagnoses per patient, and those cancer diagnoses would have different NGS reports and we wouldn't want to restrict to 1 NGS report across all dx, so I am going to open an issue to remind us that a future enhancement could be updating select_unique_ngs() to be unique at the diagnosis rather than at the patient level.

@jalavery jalavery added the enhancement New feature or request label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant