You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
select_unique_ngs() is currently based on selecting a unique NGS per patient (among the diagnoses subset on cohort_ngs), which is almost always going to be the structure of the diagnosis dataset returned from create_analytic_cohort(), so this is perfect for now. It is technically possible for someone to pull multiple cancer diagnoses per patient, and those cancer diagnoses would have different NGS reports and we wouldn't want to restrict to 1 NGS report across all dx, so I am going to open an issue to remind us that a future enhancement could be updating select_unique_ngs() to be unique at the diagnosis rather than at the patient level.
The text was updated successfully, but these errors were encountered:
select_unique_ngs()
is currently based on selecting a unique NGS per patient (among the diagnoses subset oncohort_ngs
), which is almost always going to be the structure of the diagnosis dataset returned fromcreate_analytic_cohort()
, so this is perfect for now. It is technically possible for someone to pull multiple cancer diagnoses per patient, and those cancer diagnoses would have different NGS reports and we wouldn't want to restrict to 1 NGS report across all dx, so I am going to open an issue to remind us that a future enhancement could be updatingselect_unique_ngs()
to be unique at the diagnosis rather than at the patient level.The text was updated successfully, but these errors were encountered: